ObservabilityPolicy Enhancement Proposal #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
sjberman
added
enhancement
sjberman
commented
Apr 2, 2024
pleshakov
reviewed
Apr 3, 2024
sjberman
force-pushed
the
docs/proposals/observability-policy
branch
from
5f19a33
to
d68ca07
Compare
pleshakov
approved these changes
Apr 4, 2024
kate-osborn
reviewed
Apr 4, 2024
Problem: We want a design for Observability-related configuration settings, such as tracing, to be applied at the HTTPRoute level. Solution: Add enhancement proposal introducing `ObservabilityPolicy`.
sjberman
force-pushed
the
docs/proposals/observability-policy
branch
from
b855c1d
to
14457ff
Compare
kate-osborn
approved these changes
Apr 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1795 +/- ##
==========================================
- Coverage 86.20% 86.18% -0.03%
==========================================
Files 83 87 +4
Lines 5540 5522 -18
Branches 52 52
==========================================
- Hits 4776 4759 -17
- Misses 715 717 +2
+ Partials 49 46 -3 ☔ View full report in Codecov by Sentry. |
1 task
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: We want a design for Observability-related configuration settings, such as tracing, to be applied at the HTTPRoute level.
Solution: Add enhancement proposal introducing
ObservabilityPolicy.Closes #1662
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.